Conversation
Mistobaan
force-pushed
the
Mistobaan/add-docwebsite
branch
3 times, most recently
from
9af30de to
d65cc5f
Compare
|
Can you state what are the main changes done here? Also it seems that you accidentally reverted a few prior commits off of current master |
setup.py
Outdated
| "flake8 >= 3.8.3", | ||
| ] | ||
| extras["docs"] = ["sphinx==4.0.0", "sphinx_rtd_theme"] | ||
| extras["test_prod"] = ["pytest", "pytest-xdist", "pytest-subtests", "parameterized"] |
There was a problem hiding this comment.
What does this get us over just using setup.cfg?
There was a problem hiding this comment.
setup.cfg is actually the right way. will fix.
Mistobaan
force-pushed
the
Mistobaan/add-docwebsite
branch
from
88b6fda to
f49a6d9
Compare
jon-tow
left a comment
jon-tow
left a comment
There was a problem hiding this comment.
@Mistobaan This looks great 🚀 I left a few comments and change requests when you get a chance. Thank you!
CONTRIBUTING.md
Outdated
| 1. Setup your environment: | ||
|
|
||
| ```bash | ||
| conda create -n trlx python=3.8 torch torch-cuda=11.7 -c pytorch -c nvidia | ||
| git clone https://github.com/CarperAI/trlx | ||
| cd trlx | ||
| pip install -e ".[dev]" | ||
| pre-commit install | ||
| ``` |
There was a problem hiding this comment.
Remove this. Most of it is repeated below.
|
Hi, @Mistobaan! Is there anywhere that I can lend a hand to help push this along? |
Mistobaan
force-pushed
the
Mistobaan/add-docwebsite
branch
from
9146e8b to
dd0ecc7
Compare
|
@jon-tow I have to just find some time to reduce the patch and make it more manageable. The first delta is always tricky then the next documentations should be fine |
Mistobaan
force-pushed
the
Mistobaan/add-docwebsite
branch
from
dd0ecc7 to
77d6ba2
Compare
|
Simplified the PR, latest preview here: https://trlx-docs-preview.readthedocs.io/en/latest/ |
Mistobaan
force-pushed
the
Mistobaan/add-docwebsite
branch
from
77d6ba2 to
c5cfc13
Compare
jon-tow
left a comment
jon-tow
left a comment
There was a problem hiding this comment.
Added a few more nits and cleanups to reflect recent changes. The preview docs look great!
Mistobaan
force-pushed
the
Mistobaan/add-docwebsite
branch
from
07dc763 to
c5cfc13
Compare
|
Hey what are we doing here |
5 participants
First iteration on the new website documentation
https://trlx-docs-preview.readthedocs.io/en/latest/