Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Conversation

@pramsey
Copy link
Contributor

@pramsey pramsey commented Jul 24, 2015

No description provided.

@pramsey
Copy link
Contributor Author

pramsey commented Jul 24, 2015

Review, @rochoa ? @javisantana ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😈

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not like schema_triggers :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

har de har. We are a smidge better about that, after this patch (though we'll still break standard usage of event triggers in favor of our own).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the standard usage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say that the implementation described here http://www.postgresql.org/docs/9.4/static/sql-createeventtrigger.html would be over-ridden, but I'd have to read deeper to find out for sure. The over-ride in this code block is just capturing all CREATE EVENT TRIGGER commands, but farther down the code is still populating the pg_event_trigger system table, so the default implementation might still be perfectly happy.

@rochoa
Copy link

rochoa commented Jul 31, 2015

As far as I understand this I'm OK with the changes.

@pramsey
Copy link
Contributor Author

pramsey commented Aug 4, 2015

Should point out that this is in response to #4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants