Skip to content

Add unit tests for DailyReport #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CascadePass merged 2 commits into from
Feb 10, 2025
Merged

Add unit tests for DailyReport #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bae592
Add 5 non-trivial tests
CascadePass Feb 7, 2025
f5d5981
Add more tests, fix 1 edge case
CascadePass Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions cpap-lib/DailyReport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,24 @@ public void UpdateSignalStatistics( string signalName )
/// </summary>
public void RefreshTimeRange()
{
RecordingStartTime = Sessions.Min( x => x.StartTime );
RecordingEndTime = Sessions.Max( x => x.EndTime );
TotalSleepTime = CalculateTotalSleepTime();
}
if (Sessions.Count != 0)
{
RecordingStartTime = Sessions.Min(x => x.StartTime);
RecordingEndTime = Sessions.Max(x => x.EndTime);
TotalSleepTime = CalculateTotalSleepTime();
}
else
{
// If there are no sessions, reset the time range values to their defaults.

// It's a bug to call this function when there are no sessions, but we'll handle it gracefully.
// Without this check, an exception would be thrown.

RecordingStartTime = default;
RecordingEndTime = default;
TotalSleepTime = default;
}
}

/// <summary>
/// Adds a new Session to the Sessions list and updates the RecordingStartTime and RecordingEndTime
Expand Down
Loading
Loading