Fixing build issue related to new "na.print" argument in data.table #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks Toby @tdhock for bringing this to my attention via issue in data.table.
Recently, a new argument was added to
print.data.table
, which affected re-building of vignettes, as outlined in the original issue. Credit to @MichaelChirico for the find; the issue was here:TrialEmulation/R/generics.R
Line 50 in 989f064
With the new
na.print
argument,n = 5
is no longer partially matched tonrows
, so the change is trivial. I've also gone ahead and taken a quick look at other function calls that could avoid partial matching in its arguments, and changed those as well.