Skip to content

Fixing build issue related to new "na.print" argument in data.table #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024

Conversation

joshhwuu
Copy link
Contributor

@joshhwuu joshhwuu commented Apr 22, 2024

Thanks Toby @tdhock for bringing this to my attention via issue in data.table.

Recently, a new argument was added to print.data.table, which affected re-building of vignettes, as outlined in the original issue. Credit to @MichaelChirico for the find; the issue was here:

print(data.table(data = object$data), topn = 3, n = 5, col.names = "none", ...)

With the new na.print argument, n = 5 is no longer partially matched to nrows, so the change is trivial. I've also gone ahead and taken a quick look at other function calls that could avoid partial matching in its arguments, and changed those as well.

@gravesti
Copy link
Contributor

gravesti commented May 6, 2024

Thanks @joshhwuu for this PR and apologies I didn't notice it earlier. Will update on CRAN as soon as possible

@gravesti gravesti merged commit 583fd42 into Causal-LDA:main May 6, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants