Skip to content

149 read expanded data for duckdb #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

darkgoldenrod-cherry
Copy link
Collaborator

No description provided.

@darkgoldenrod-cherry darkgoldenrod-cherry linked an issue Jun 11, 2024 that may be closed by this pull request
6 tasks
@darkgoldenrod-cherry darkgoldenrod-cherry marked this pull request as ready for review June 11, 2024 13:58
Copy link
Contributor

github-actions bot commented Jun 11, 2024

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ------------------------------------------------------------
R/calculate_weights.R      117     117  0.00%    2-159
R/data_extension.R         119       1  99.16%   146
R/data_manipulation.R       56       0  100.00%
R/data_preparation.R       163      12  92.64%   141-142, 197-200, 258-259, 269-270, 284-285
R/data_simulation.R         78       6  92.31%   77, 80, 148-152
R/data_utils.R             136      20  85.29%   41-42, 136-144, 156-164
R/expand_trials.R           28      28  0.00%    2-32
R/generics.R                54       2  96.30%   106-107
R/initiators.R              48       1  97.92%   134
R/lr_utils.R                23       0  100.00%
R/modelling.R               98      24  75.51%   63, 72-74, 82, 85-86, 90, 103-105, 113-116, 122-127, 131-134
R/predict.R                 87      17  80.46%   87, 136-151
R/robust.R                  18       0  100.00%
R/sampling.R                53       4  92.45%   58-60, 106
R/te_data.R                  3       3  0.00%    42-44
R/te_datastore.R            57       5  91.23%   50, 53, 114, 116, 165
R/te_weights.R              34      34  0.00%    68-182
R/trial_sequence.R         183     133  27.32%   95, 97, 109-136, 199-214, 296-553, 587-588, 616, 643-700
R/utils.R                   29       2  93.10%   134-147
R/weighting.R              202       9  95.54%   175-186
src/code.cpp                81       6  92.59%   101-106
TOTAL                     1667     424  74.57%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/te_datastore.R        +16     -13  +35.13%
R/trial_sequence.R        0     -50  +27.32%
TOTAL                   +16     -63  +4.06%

Results for commit: a4cd22e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jun 11, 2024

Unit Tests Summary

  1 files   12 suites   1m 5s ⏱️
 74 tests  57 ✅ 17 💤 0 ❌
183 runs  158 ✅ 25 💤 0 ❌

Results for commit a4cd22e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jun 11, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
te_datastore 👶 $+0.12$ read_expanded_data_can_read_te_datastore_datatable_data
te_datastore 👶 $+0.19$ read_expanded_data_can_read_te_datastore_duckdb_data

Results for commit 4eb1587

♻️ This comment has been updated with latest results.

@gravesti gravesti self-requested a review June 12, 2024 13:34
…cts keeps factor variables, removed data calls from test file
Copy link
Contributor

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

@gravesti gravesti merged commit 30e212e into main Jun 13, 2024
24 checks passed
@gravesti gravesti deleted the 149-read_expanded_data-for-duckdb branch June 13, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_expanded_data for duckdb
2 participants