Improve memory usage in bootstrapping and some other small fixes#149
Merged
Improve memory usage in bootstrapping and some other small fixes#149
Conversation
…on to prevent accumulation of large matrices (x, y, residuals, qr, etc.) across all iterations simultaneously
…presents survival after k intervals with the final estimate at followup=survival.max+1
…represents survival after k intervals and output extends to survival.max+1
…incorrectly carried forward with outcome=0 rows from subsequent periods by truncating each trial at the first event row
ryan-odea
approved these changes
Apr 15, 2026
Collaborator
ryan-odea
left a comment
ryan-odea
left a comment
There was a problem hiding this comment.
This looks very good! Great work!
Collaborator
Author
|
thanks Ryan (and post merge I have remembered to delete my branches 😄) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main thing this does is,
Other small amends and fixes,
Remove mention of units from time in docs.
Fix off-by-one labeling in survival output so that
followup = kcorrectly represents survival afterkintervals, adding a row atfollowup = survival.max + 1for the final interval's estimate.Fix expansion bug where subjects experiencing the outcome early were incorrectly carried forward with
outcome=0rows from subsequent periods by truncating each trial at the first event rowFix a tiny formatting issue on https://causalinference.github.io/SEQTaRget/news/index.html - will now render as
@outcome.model