Implement fixed heatmap legend range for issue #224#255
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @FedericoTartarini - This PR addresses #224 Dynamic heatmap legend in Natural Ventilation tab. When you have a moment, could you please review? Thank you! |
|
Hi @FedericoTartarini - Just wanted to check — if there’s no issue with the latest pull request, would it be fine to merge it? Of course, please let us know if you’d like us to make any additional changes before merging. |
|
I am very sorry I forgot to approve the request. I have just run the checks and they are not passing because the code is not formatted properly. Could you please implement that and then I will accept the request? |
adc5764
into
CenterForTheBuiltEnvironment:development
|
Hi, @FedericoTartarini - We have already done the ruff check. Could you please take a check when you have a moment? |
Summary
This PR addresses and resolves open issue #224 (Dynamic heatmap legend in Natural Ventilation tab). In the previous implementation, the heat map color scale range(legend) dynamically changes with filters, leading to poor comparability and increased cognitive load. The current modification calculates and fixes the color scale range based on the full-year data, explicitly passing it to the plotting function to ensure consistent color meaning across different filter conditions, thereby improving comparability and user experience.
Changes