added functionality to export results to txt file#23
added functionality to export results to txt file#23FedericoTartarini wants to merge 3 commits intoCenterForTheBuiltEnvironment:masterfrom
Conversation
…These data can be then processed using the Python code in process_data_ashrae.py to generate the tables for the ASHRAE standard. This functionality is disabled by default but it can be activated by setting output_data_for_ASHRAE_table = true
|
@thoyt could you please also review the changes and accept the Pull request? |
thoyt
left a comment
thoyt
left a comment
There was a problem hiding this comment.
The python looks like personal scripting used to analyze and visualize the downloaded data. I think the code in this repo should be for the general purpose application.
It should be possible to focus on the export part and make that very reliable and usable. In this scenario you would have to be a power user and set the special javascript variable to true and read the comments for instructions on how to use it. Is there a reason not to create a csv download button that downloads the whole dataset and leave the postprocessing to users?
Maybe I don't know the goal here but I imagine we want a simple button for downloading.. @praftery ?
|
You are right, I will remove the folder named ASHRAE 55 Tables from the project. I used the Python code to generate the tables for David however, there is no need to add this code to the GitHub repository. I will now send a new commit to fix the above mentioned issues. |
2 participants
No description provided.