Conversation
The inline style isn’t processed with autoprefixer, so it needs to be there for WebKit browsers.
* Switches main navigation and panes to use sticky positioning. * Requires panes and main content area to be wrapped when used together.
Contributor
|
@jsmecham is this still relevant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the shell (i.e.
<main-nav>,<account-switcher>,<pane>, ...) layout to use Flexbox. This started out as an attempt to use Flexbox without requiring any markup changes, but unfortunately, it is not backwards compatible as a new wrapper element is required for correct responsive/mobile support.Changes
position: stickyon<main-nav>and<pane>contents in place of scroll observers.<main-nav>is now handled natively withoverflowin place of buttons to scroll up and down with JavaScript..main-wapper) that allows us to properly layout panes in mobile or responsive modes.position: stickyto work correctly.Notes