Skip to content

CePO#1

Open
pawelf-cerebras wants to merge 71 commits intomainfrom
cepo
Open

CePO#1
pawelf-cerebras wants to merge 71 commits intomainfrom
cepo

Conversation

@pawelf-cerebras
Copy link
Copy Markdown
Collaborator

@pawelf-cerebras pawelf-cerebras commented Dec 19, 2024

Adding Cerebras Planning and Optimization (CePO). On high-level, in CePO, we make m attempts to generate n step-by-step plans, refine the plans, check inconsistencies between them, use the above feedback to generate the final plan and produce the answer. This process is them repeated N times in a classical best of n manner.

  • Added implementation of CePO
  • Integrated CePO with optillm

Comment thread optillm/cepo.py Outdated
@erich-cerebras
Copy link
Copy Markdown

Do we also want to maybe edit the ReadMe.md here: https://github.com/CerebrasResearch/cb_optillm/blob/cepo/README.md#implemented-techniques ?

This will allow users to do the following:
1. Cli where if they can pass in anything that's "cepo_<name-of-attribute>"
2. Yaml file where if they pass it in as "<name-of-attribute>"
3. If none of them have a specific attribute, we use the default setting
4. If both of them have the specific attribute, we error out
Copy link
Copy Markdown

@erich-cerebras erich-cerebras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments, besides that it LGTM!

Comment thread optillm/cepo.py Outdated
Comment thread optillm/cepo.py Outdated
@pawelf-cerebras pawelf-cerebras changed the title Cepo CePO Jan 2, 2025
@pawelf-cerebras pawelf-cerebras marked this pull request as ready for review January 2, 2025 18:06
Comment thread configs/cepo_config.yaml
Comment thread optillm/cepo.py Outdated
Comment thread optillm/cepo.py Outdated
Comment thread optillm/cepo.py
Comment thread optillm/cepo.py Outdated
Comment thread README.md
Comment thread optillm/cepo.py Outdated
Copy link
Copy Markdown

@vithursant vithursant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, overall looking good.

Comment thread optillm/cepo.py
@@ -0,0 +1,314 @@
import re
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pawelf-cerebras I think we should add LICENSE for the cepo code. In the past we've done something like this.

https://github.com/CerebrasResearch/Sparse-IFT/blob/master/cbsparse/LICENSE

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pawelf-cerebras did you have any thoughts on this?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for pointing this out. We're going to add the license. I mentioned this last week to Emma and she's making sure with the legal team that everything is good. I want to leave this comment unresolved until I hear from her and add the license.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Comment thread optillm/cepo.py Outdated
Comment thread optillm/cepo.py Outdated
Comment thread optillm/cepo.py
Comment thread optillm/cepo.py Outdated
Comment thread optillm/cepo.py
Comment thread optillm/cepo.py Outdated
Comment thread optillm/cepo.py Outdated
codelion and others added 30 commits January 20, 2025 11:17
- yield response to allow clients that expect streaming
- add dockerignore
- parameterize port in dockerfile
prepare for new release
prepare for new release
- handle multiple responses as multiple attempts
- prepare for new release
fix inference on amd gpu
This will allow users to do the following:
1. Cli where if they can pass in anything that's "cepo_<name-of-attribute>"
2. Yaml file where if they pass it in as "<name-of-attribute>"
3. If none of them have a specific attribute, we use the default setting
4. If both of them have the specific attribute, we error out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants