Added rowPitch field to ImageAssetMipPosition struct. #1259
Open
david-lively wants to merge 7 commits intomainfrom
Open
Added rowPitch field to ImageAssetMipPosition struct. #1259david-lively wants to merge 7 commits intomainfrom
david-lively wants to merge 7 commits intomainfrom
Conversation
…en flipping textures in Unity.
5 tasks
j9liu
reviewed
Oct 9, 2025
Contributor
j9liu
left a comment
j9liu
left a comment
There was a problem hiding this comment.
Thanks @david-lively for the PR! Just a handful of small comments, nothing too major.
Contributor
There was a problem hiding this comment.
Remember to update CHANGES.md!
Co-authored-by: Janine Liu <32226860+j9liu@users.noreply.github.com>
Co-authored-by: Janine Liu <32226860+j9liu@users.noreply.github.com>
Co-authored-by: Janine Liu <32226860+j9liu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
ImageAssetMipPosition::rowPitchfield. This is used incesium-unitywhen loading textures when flipping them vertically to match Unity's U-right, V-up convention.This should be released in conjunction with CesiumGS/cesium-unity#611 .