Added support in the glTF codegen to force optional props as required#1310
Merged
Added support in the glTF codegen to force optional props as required#1310
Conversation
j9liu
reviewed
Feb 18, 2026
Contributor
j9liu
left a comment
j9liu
left a comment
There was a problem hiding this comment.
Thanks @weegeekps ! This looks great to me, just one comment about conventions for our codebase.
j9liu
reviewed
Feb 18, 2026
Contributor
|
Merging now, thanks @weegeekps ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new
KHR_gaussian_splattingspecification we're recommending that writers include the optional valuesprojectionandsortingMethodfor maximum interoperability. Both of these values are marked optional because they can be ignored by renderers in some cases, but we should follow this advice despite not using them ourselves.This PR adds support so we can mark optional props as required in the code generator configuration file. It also includes an updated
ModelJsonWriter.cppwith this already applied forKHR_gaussian_splatting.