Cylinder voxels #1719
Open
Cylinder voxels #1719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #1711, so merge that first.
This PR adds support for loading and rendering cylinder-based voxels. This grid shape is useful for geospatial use cases where data is captured with cylindrical sensors.
Author checklist
Testing plan
The dataset pictured above can be found at in the CesiumJS SampleData folder. Give the tileset a small Maximum Screen Space Error, like 4, otherwise the data may not show up. You can compare it with its appearance in CesiumJS by selecting the Cylinder option in this Sandcastle.
You can also edit the
3DTILES_bounding_volume_cylinderintileset.jsonto play around withminRadius,minAngle, andmaxAngle, verifying that the volume deforms according to the new shape bounds.