Fix point-rendering regression where square points become circular#13219
Merged
mzschwartz5 merged 5 commits intomainfrom Feb 19, 2026
Merged
Fix point-rendering regression where square points become circular#13219mzschwartz5 merged 5 commits intomainfrom
mzschwartz5 merged 5 commits intomainfrom
Conversation
…ther than the context of the glTF point size extension
|
Thank you for the pull request, @markschlosseratbentley! ✅ We can confirm we have a CLA on file for you. |
There was a problem hiding this comment.
Pull request overview
Fixes a rendering regression in the model/point pipeline so that POINTS primitives render as squares by default again, and only render as circles when explicitly required by the BENTLEY_materials_point_style glTF extension (via pointDiameter).
Changes:
- Restrict circular point fragment discard logic to
PRIMITIVE_TYPE_POINTS && HAS_POINT_DIAMETERinModelFS.glsl. - Ensure
HAS_POINT_DIAMETERis defined in both vertex and fragment shader stages whenmaterial.pointDiameteris present. - Add unit tests covering the presence/absence of
pointDiameterbehavior and uniform wiring.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/engine/Specs/Scene/Model/MaterialPipelineStageSpec.js | Adds test coverage and a pixelRatio mock to validate HAS_POINT_DIAMETER + u_pointDiameter behavior. |
| packages/engine/Source/Shaders/Model/ModelFS.glsl | Makes circular point rendering conditional on HAS_POINT_DIAMETER to restore square-by-default points. |
| packages/engine/Source/Scene/Model/MaterialPipelineStage.js | Emits HAS_POINT_DIAMETER to both shader stages so fragment shader can gate circle discard logic. |
| CHANGES.md | Documents the regression fix and the extension-specific behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mzschwartz5
approved these changes
Feb 19, 2026
Contributor
mzschwartz5
left a comment
mzschwartz5
left a comment
There was a problem hiding this comment.
Everything here looks good to me - no comments!
mzschwartz5
deleted the
markschlosser/fix-gltf-point-size-rounded-for-all
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a point-rendering regression which caused points to render as circles rather than squares. Such points now will only render as circles when their width is specified via the BENTLEY_materials_point_style glTF extension (which requires that such points be circular).
Issue number and link
Fixes #13217
Testing plan
3d-tiles-point-cloud-shadingsample now renders square points.styled-gltf-points-devstill renders circular points, per the glTF extension specification.Reviewers can verify these changes at these deployed links:
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change