Skip to content

change Dockerfile to use gunicorn, requiring some changes to the app.#23

Open
stvhay wants to merge 5 commits intoCesura:mainfrom
stvhay:Cesura-gunicorn
Open

change Dockerfile to use gunicorn, requiring some changes to the app.#23
stvhay wants to merge 5 commits intoCesura:mainfrom
stvhay:Cesura-gunicorn

Conversation

@stvhay
Copy link
Copy Markdown
Contributor

@stvhay stvhay commented Aug 30, 2022

Since i think the intent this is used in production, the Dockerfile is adjusted to use gunicorn rather than the insecure build-in WSGI server Flask uses. This required some changes to some imports in the app itself. Also adjusted the order of commands in the Dockerfile so the layers work out a bit better.

@stvhay
Copy link
Copy Markdown
Contributor Author

stvhay commented Aug 31, 2022

This is probably the most controversial pull request, so I've done it based on the assumption the others will be accepted (there were some conflicts)

There might be a cleaner way to do all of this, but it was the best I could come up with. I think the cleaner way might be to figure out how to avoid the from main import stuff that I had to put guards around and creating a wsgi.py entrypoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant