change Dockerfile to use gunicorn, requiring some changes to the app.#23
Open
stvhay wants to merge 5 commits intoCesura:mainfrom
Open
change Dockerfile to use gunicorn, requiring some changes to the app.#23stvhay wants to merge 5 commits intoCesura:mainfrom
stvhay wants to merge 5 commits intoCesura:mainfrom
Conversation
Contributor
Author
|
This is probably the most controversial pull request, so I've done it based on the assumption the others will be accepted (there were some conflicts) There might be a cleaner way to do all of this, but it was the best I could come up with. I think the cleaner way might be to figure out how to avoid the from main import stuff that I had to put guards around and creating a wsgi.py entrypoint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since i think the intent this is used in production, the Dockerfile is adjusted to use gunicorn rather than the insecure build-in WSGI server Flask uses. This required some changes to some imports in the app itself. Also adjusted the order of commands in the Dockerfile so the layers work out a bit better.