Add Grouping Support to CreateJob#16
Open
getopenwater wants to merge 3 commits intoChadBurggraf:masterfrom
Open
Add Grouping Support to CreateJob#16getopenwater wants to merge 3 commits intoChadBurggraf:masterfrom
getopenwater wants to merge 3 commits intoChadBurggraf:masterfrom
Conversation
Owner
|
I'm cool with this and appreciate the addition. However, can you remove the changes to Zencoder.cs? They break the public API and will cause build errors for anyone calling Zencoder.CreateJob (the tests project doesn't actually build with the PR applied). |
Author
|
Sorry that was my mistake. I just added app.config so I could also run the test project. I added a new overload to handle grouping. Is that okay? |
Revert last commit which broke Api Added new Overload to support grouping
|
I was just implementing this, I need PassThrough as well though, so I'll work in my local copy until this is merged in, then I'll update, add my passthrough, and put up a patch for PassThrough support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.