Skip to content

Conversation

@Chaffelson
Copy link
Owner

Previously verify_config filtered processors to only those directly in the root process group, missing processors in child PGs. This caused issues with connectors that have nested process group structures.

Also adds --only_failures option to reduce output size for large flows.

Previously verify_config filtered processors to only those directly in
the root process group, missing processors in child PGs. This caused
issues with connectors that have nested process group structures.

Also adds --only_failures option to reduce output size for large flows.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where verify_config only checked processors in the root process group and adds a new feature to filter results to show only failures.

Changes:

  • Modified _verify_processors to verify processors in all descendant process groups, not just the root PG
  • Added only_failures parameter to optionally filter results to show only failed components
  • Refactored result building to use a consolidated all_results variable for cleaner code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.58%. Comparing base (a8b7f19) to head (5152585).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nipyapi/ci/verify_config.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
- Coverage   76.65%   76.58%   -0.07%     
==========================================
  Files          41       41              
  Lines        4780     4780              
==========================================
- Hits         3664     3661       -3     
- Misses       1116     1119       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Chaffelson Chaffelson merged commit 811aa9c into main Jan 18, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants