Skip to content

fix: allow dual stack to use the same port #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wemeetagain merged 1 commit into from
Aug 12, 2025
Merged

fix: allow dual stack to use the same port #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/discv5/src/transport/udp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,6 @@ export class UDPTransportService
this.bindAddrs.push(this.ip6.addr);
this.ipMode.ip6 = true;
}
if (this.ip4 && this.ip6) {
if (this.ip4.opts.port === this.ip6.opts.port) {
throw new Error("Configured bind multiaddrs must have different ports");
}
}
}

public async start(): Promise<void> {
Expand Down
4 changes: 2 additions & 2 deletions packages/discv5/test/unit/transport/udp.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,13 @@ describe("UDP4+6 transport", () => {
const nodeIdA = bytesToHex(new Uint8Array(32).fill(1));
const portA = 49523;
const multiaddr4A = multiaddr(`/ip4/${address4}/udp/${portA}`);
const multiaddr6A = multiaddr(`/ip6/${address6}/udp/${portA + 1}`);
const multiaddr6A = multiaddr(`/ip6/${address6}/udp/${portA}`);
const a = new UDPTransportService({ bindAddrs: { ip4: multiaddr4A, ip6: multiaddr6A }, nodeId: nodeIdA });

const nodeIdB = bytesToHex(new Uint8Array(32).fill(2));
const portB = portA + 1;
const multiaddr4B = multiaddr(`/ip4/${address4}/udp/${portB}`);
const multiaddr6B = multiaddr(`/ip6/${address6}/udp/${portB + 1}`);
const multiaddr6B = multiaddr(`/ip6/${address6}/udp/${portB}`);
const b = new UDPTransportService({ bindAddrs: { ip4: multiaddr4B, ip6: multiaddr6B }, nodeId: nodeIdB });

before(async () => {
Expand Down