Skip to content

fix: check if existing outbound stream is open #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julienmalard wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: check if existing outbound stream is open #534

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67961ae
Check if existing outbound stream is open or closed before aborting s…
julienmalard Nov 13, 2025
322e5ff
Access status on rawStream
julienmalard Nov 14, 2025
c8716ba
Change to `get`
julienmalard Nov 14, 2025
888b89b
Check stream status in `directConnect`
julienmalard Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,7 @@ export class GossipSub extends TypedEventEmitter<GossipsubEvents> implements Pub
// TODO make this behavior more robust
// This behavior is different than for inbound streams
// If an outbound stream already exists, don't create a new stream
if (this.streamsOutbound.has(id)) {
if (this.streamsOutbound.get(id)?.rawStream?.status === "open") {
return
}

Expand Down Expand Up @@ -1834,7 +1834,7 @@ export class GossipSub extends TypedEventEmitter<GossipsubEvents> implements Pub
private async directConnect (): Promise<void> {
const toconnect: string[] = []
this.direct.forEach((id) => {
if (!this.streamsOutbound.has(id)) {
if (!this.streamsOutbound.get(id)?.rawStream?.status === "open") {
toconnect.push(id)
}
})
Expand Down