ht Diana by dianasinenchenko · Pull Request #3 · ChangeRequest/introduction.hw2

dianasinenchenko · 2016-11-24T19:58:14Z

No description provided.

changed

xSAVIKx · 2016-11-24T20:01:18Z

src/main/java/school/lemon/changerequest/java/introduction/hw2/Task2.java

+            String substring = shortstr.substring(0);
+            return substring;
+        }
+


It's quite uncommon way to solve this task.
Actually, there is no need for StringBuilder here - you can just use substring method of String.

Also, you can move length check to null-check, so that you'll check string for null and for length<2 and just return s.

it means like this ?6cac7fc

xSAVIKx · 2016-11-24T20:48:32Z

src/main/java/school/lemon/changerequest/java/introduction/hw2/Task1.java

+        String closetag = "</" + tag + ">";
+        String html = opentag + text + closetag;
+
+        return html;


It's OK, but IMO, it's better to solve this task with StringBuilder and the best solution will be using String.format().

fixed with string format e1d526d

xSAVIKx · 2016-11-26T06:12:32Z

src/main/java/school/lemon/changerequest/java/introduction/hw2/Task1.java

-        return html;
+
+        return String.format("%s", "<" + tag + ">"
+                + text + "</" + tag + ">");


You are almost done.
Now, there is no need to use only one %s in format.
Also, you can combine format with any symbols, so that it should look like: <%s>%s...

xSAVIKx · 2016-11-27T10:32:00Z

src/main/java/school/lemon/changerequest/java/introduction/hw2/Task4.java

+        if (i > 0 && i >= s.length()) {
+            i = i - s.length();
+        }
+        return String.valueOf(s.charAt(i));


Your implementation pass all tests, but you've used lots of unnecessary operations and it'll be quite slow (due to additional usage of Math and StringBuilder.
Try to solve this task from Math point of view - you just need to calculate char index properly and this could be done using % operator.

i didn't have any idea. what do you mean about use % operator ?

% - is modulus operator in Java.
For example for positive index, result index on which you can get needed char could be calculated in following way:
int index %=s.length().

oh, interesting. thx

xSAVIKx · 2016-11-27T10:35:41Z

src/main/java/school/lemon/changerequest/java/introduction/hw2/Task5.java

+            return a[0] == b[0] || a[a.length - 1] == b[b.length - 1] || a[0] == b[b.length - 1] || a[a.length - 1] == b[0];
+        }
        return false;
    }


And again. It do pass all tests, but it's again to complicated.
Why do you need this if clause ? Also there is no need for lengthA and lengthB vars (or you should reuse them everywhere).
By the task description: you'll 100% have arrays with length>=1.

xSAVIKx · 2016-11-27T18:54:18Z

src/main/java/school/lemon/changerequest/java/introduction/hw2/Task5.java

+
        return false;
+
+


you don't need if clause, as result of your expression is boolean - you can just return it.

you should cover one more case - last a is equal to last b.

xSAVIKx · 2016-11-28T07:14:05Z

src/main/java/school/lemon/changerequest/java/introduction/hw2/Task6.java

+        for (int i = arr.length - 1; i >= 0; --i) {
+            reverseArr[i] = arr[n];
+            n++;
+        }


You can create more complex for condition:

for (int i = arr.length - 1, n=0; i >= 0 && n<arr.length; i--, n++) { reverseArr[i] = arr[n]; }

But, actually, this task could be solved with only one index variable.

xSAVIKx · 2016-11-28T07:15:32Z

src/main/java/school/lemon/changerequest/java/introduction/hw2/Task7.java

+        }
+        int n = 0;
+        for (int i = arr.length - 1; i >= 0; --i)
+            if (arr[i] % 2 == 0 || arr[i] == 0) {


There is no need for you additional condition arr[i]==0 cause even when arr[i] will be 0 - 0%2 ==0 will return true.

xSAVIKx · 2016-11-30T19:04:57Z

@dianasinenchenko Please remove wrong import from Task6, cause due to this import your code could not be compiled.

xSAVIKx · 2016-11-30T20:01:11Z

@dianasinenchenko What about task 9 and task 10 ?

dianasinenchenko · 2016-11-30T20:14:40Z

@xSAVIKx i try writing correct pattern for task 9. will be today

xSAVIKx · 2016-12-01T14:07:54Z

@dianasinenchenko What exact problems do you have ? If you need any assistance - it's better to ask questions via Gitter

xSAVIKx · 2016-12-01T19:16:17Z

src/main/java/school/lemon/changerequest/java/introduction/hw2/Task9.java

+        StringBuilder surl = new StringBuilder();
+        if (murl.find()){
+           surl.append(murl.group()).append("\n");
+        return new String[]{surl.toString()};


Try to avoid such naming.
Characters are free of charge now and you can easily create names with any length.
Also, follow lowerCamelCase for variables names.
Following names would be better:
url -> regexp
purl -> urlPattern
murl -> urlMatcher
surl -> result.
Also, you need to provide String[3] array and with current implementation you'll supply String[1] array, as surl.toString() will create one String object.

xSAVIKx · 2016-12-01T19:19:09Z

src/main/java/school/lemon/changerequest/java/introduction/hw2/Task9.java

-        Matcher mhost = phost.matcher(URL);
-        Matcher mport = pport.matcher(URL);

+String url =" ( (?<=\\:\\/\\/) [\\w] +.) ? ((?<= \\/\\/) [\\w\\d.-_] +.) ((?<=\\: ) [\\d] ) ";


I'm pretty sure, that your regexp is not correct.
Schema could contain only [a-zA-Z0-9].
Host could contain [a-zA-Z0-9-_.]
Port could have more than 1 number

dianasinenchenko added 4 commits November 24, 2016 15:25

1 done

3a2d2c4

2 not all (i have some trouble with null)

5fa2973

2 done

59786c3

changed

3 done

dc94af1

xSAVIKx self-assigned this Nov 24, 2016

xSAVIKx requested changes Nov 24, 2016

View reviewed changes

dianasinenchenko added 2 commits November 25, 2016 21:46

1 done ( with String.format() )

e1d526d

2 done ( check string for null and for length<2 together )

6cac7fc

xSAVIKx requested changes Nov 26, 2016

View reviewed changes

4 done

b096078

dianasinenchenko changed the title ~~ht Diana (1-3)~~ ht Diana (1-4) Nov 26, 2016

5 done

ca9406c

xSAVIKx requested changes Nov 27, 2016

View reviewed changes

5 done (changed)

7b2f9bd

dianasinenchenko changed the title ~~ht Diana (1-4)~~ ht Diana (1-5) Nov 27, 2016

xSAVIKx requested changes Nov 27, 2016

View reviewed changes

dianasinenchenko added 3 commits November 27, 2016 21:34

5 done (changed without if )

76c2630

6 done

f189030

7 done

c70745e

dianasinenchenko changed the title ~~ht Diana (1-5)~~ ht Diana (1-7) Nov 27, 2016

xSAVIKx requested changes Nov 28, 2016

View reviewed changes

dianasinenchenko added 4 commits November 28, 2016 14:18

6 done

0a8c370

6 done (changed)

238deb2

7 done (changed)

8fd98d1

8 done

22ea85d

6 done (without import)

7bd5d21

9 not all (i have with this much problems )

1b5a143

dianasinenchenko added 2 commits December 1, 2016 17:20

9 not all

80f5ff3

9 changed but smt wrong 10 done

73057ce

xSAVIKx requested changes Dec 1, 2016

View reviewed changes

dianasinenchenko changed the title ~~ht Diana (1-7)~~ ht Diana Dec 2, 2016

Comments

Conversation

dianasinenchenko commented Nov 24, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xSAVIKx commented Nov 30, 2016

Uh oh!

xSAVIKx commented Nov 30, 2016

Uh oh!

dianasinenchenko commented Nov 30, 2016

Uh oh!

xSAVIKx commented Dec 1, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants