1,2 Tasks from PR1 done#7
Open
yarikpavlin wants to merge 2 commits intoChangeRequest:masterfrom
yarikpavlin:master
Open
1,2 Tasks from PR1 done#7yarikpavlin wants to merge 2 commits intoChangeRequest:masterfrom yarikpavlin:master
yarikpavlin wants to merge 2 commits intoChangeRequest:masterfrom
yarikpavlin:master
Conversation
didva
requested changes
Nov 28, 2016
| boolean start = true; | ||
| while (start) { | ||
| System.out.println("Make your choice."); | ||
| Scanner sc = new Scanner(System.in); |
There was a problem hiding this comment.
Creating scanner in each iteration is not a good idea.
|
|
||
| private static void exit() { | ||
| System.out.println("Bye-bye"); | ||
| System.exit(0); |
There was a problem hiding this comment.
It's a bad practice to use System.exit(). Please get rid of it.
|
|
||
| } | ||
|
|
||
| private static void help() { |
| System.out.println("Make your choice."); | ||
| Scanner sc = new Scanner(System.in); | ||
| String choice = sc.nextLine(); | ||
| choice.toLowerCase(); |
There was a problem hiding this comment.
It's not working properly because string is immutable. Please read documentation about string methods.
| case "help": | ||
| help(); | ||
| break; | ||
| default: |
There was a problem hiding this comment.
I'd prefer print help message by default.
| System.out.println("Enter second number:"); | ||
| b = sc.nextInt(); | ||
| result = a / b; | ||
| System.out.println("Result of " + a + "/" + b + " is " + result); |
| System.exit(0); | ||
| } | ||
|
|
||
| private static void div() { |
There was a problem hiding this comment.
There are too many duplicated code... Reading two integers for example. Maybe you can get rid of it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 task will be done soon