Open
Conversation
didva
requested changes
Dec 10, 2016
| } | ||
|
|
||
| // normalized | ||
| private static int normalized (int d1, int d2) { |
|
|
||
|
|
||
|
|
||
| public static void main(String[] args) { |
Contributor
There was a problem hiding this comment.
Please move main method to some other class.
| return (a*d) + "/" + (b*c); | ||
| } | ||
|
|
||
| public static final FractionNumber zero = new FractionNumber (0); |
Contributor
There was a problem hiding this comment.
Please rename constants to upper case.
| return (a*c) + "/" + (b*d); | ||
| } | ||
|
|
||
| public String divFraction(FractionNumber otherFraction) { |
Contributor
There was a problem hiding this comment.
All these math methods should return FractionNumber
| private int d2; //divisor | ||
|
|
||
| //no arguments constructor | ||
| public FractionNumber(){ |
Contributor
There was a problem hiding this comment.
No need in this constructor.
| //constructor d1 and d2 | ||
| public FractionNumber(int d1, int d2) { | ||
| if(d2 == 0) throw new IllegalArgumentException("Divisor is zero"); | ||
| this.d1 = d1; |
Contributor
There was a problem hiding this comment.
Please add normalization on object creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.