PyO3 v0.25 refactoring #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacomago
reviewed
May 21, 2025
pyreccaster/src/lib.rs
Outdated
| let properties = PyDict::new(py); | ||
| fn properties(&self) -> PyResult<HashMap<String, String>> { | ||
| let mut properties: HashMap<String, String> = HashMap::new(); | ||
| for (key, value) in &self.0.properties { |
Contributor
There was a problem hiding this comment.
Seems weird to do a for loop for this, can't we just return something like properties.deep_clone()
Contributor
Author
There was a problem hiding this comment.
I am not sure how deep/shallow is the clone trait implementation in the Hashmap code. the docs says "Returns a copy of the value."
I've test .clone(), it seem to work fine.
jacomago
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some changes in PyO3 v0.25. A refactor was needed to move from PyO3 0.20 to the latest PyO3 version.
Which let me use the PyO3 maintained async library. See the Issue #2 for the background story.