Skip to content

Conversation

@tynanford
Copy link
Contributor

@tynanford tynanford commented Jun 17, 2025

Version 1.7 of recsync changed how the CF configuration settings work. Now if you set recordDesc, recordType, iocConnectionInfo, or alias in the cf.conf file then they automatically are enabled. The code doesn't check if the setting is "on" or "off". In addition iocConnectionInfo was supposed to be on by default but with this change now you have to define it in the configuration file.

This adds back the checks for these properties and forces the user to set recordDesc, alias, and recordType explicitly to "on" like before.

@tynanford tynanford requested review from jacomago and shroffk June 17, 2025 23:07
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@jacomago
Copy link
Contributor

Why explicitly check if the field is "on" rather than just set like normal boolean flags?

Also, the reason I removed it because it was inconsistent throughout, whether the flag was set vs "on"

@tynanford
Copy link
Contributor Author

Why explicitly check if the field is "on" rather than just set like normal boolean flags?

Because this is how recceiver configuration has been working since 2018 #33

iocConnectionInfo was originally set to be enabled by default. This is changed now in 1.7 and you have to uncomment the setting in the conf file to get it to work. And confusingly uncommenting this line enables iocConnectionInfo

# Uncomment line below to turn off the feature to add CA/PVA port info for name server to channelfinder
#iocConnectionInfo = off

Right now you can only disable the setting by either commenting it out or setting it to a blank string. It looks like using self.conf.getboolean works well though and is backwards compatible so I will close this PR in favor of #110

@tynanford tynanford closed this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants