switch type hints to be py36 compatible #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
simon-ess
approved these changes
Sep 25, 2025
Contributor
simon-ess
left a comment
simon-ess
left a comment
There was a problem hiding this comment.
I would like to say we should drop py3.6, but given that we also run a Centos7 facility here, I think that would be shooting ourselves in the food 😄
Contributor
Author
|
sounds like we need to add python 2.7 to the CI then! 😂 |
Contributor
|
😱 |
Contributor
|
Actually we use a python 3.13 container... So at ESS we can remove py36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#105 added some type hint syntax which is only available on python 3.9+ . This updates it to be backward compatible to the target 3.6 version
Also added 3.6 and 3.7 to the CI with a docker container since there aren't any ubuntu runners that support python < 3.8 - actions/setup-python#1048 . And added 3.13 to the build-server CI
I'm not sure why the CI for the container tests are failing and if it's related to this or not.Re-ran the failed tests and it worked