Test restarting channelfinder works ok #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacomago
force-pushed
the
cf_restart_test
branch
from
76c2dac to
aaa3f72
Compare
jacomago
force-pushed
the
cf_restart_test
branch
from
aaa3f72 to
efddc55
Compare
jacomago
requested review from
anderslindho,
mdavidsaver,
shroffk,
simon-ess and
tynanford
simon-ess
reviewed
Oct 29, 2025
server/tests/test_restart.py
Outdated
Comment on lines
65
to
77
| def test_channels_same_after_restart(self, setup_compose: DockerCompose, cf_client: ChannelFinderClient) -> None: # noqa: F811 | ||
| channels_begin = cf_client.find(name="*") | ||
| restart_container(setup_compose, "cf") | ||
| assert wait_for_sync(cf_client, check_connection_active) | ||
| channels_end = cf_client.find(name="*") | ||
| assert len(channels_begin) == len(channels_end) | ||
| channels_match(channels_begin, channels_end, PROPERTIES_TO_MATCH) | ||
| shutdown_container(setup_compose, "ioc1-1") | ||
| assert wait_for_sync( | ||
| cf_client, lambda cf_client: check_channel_property(cf_client, "IOC1-1:Msg-I", INACTIVE_PROPERTY) | ||
| ) | ||
| channels_inactive = cf_client.find(property=[("iocName", "IOC1-1")]) | ||
| assert all(INACTIVE_PROPERTY in ch["properties"] for ch in channels_inactive) |
Contributor
There was a problem hiding this comment.
This seems like two separate tests...
Co-authored-by: anderslindho <44849690+anderslindho@users.noreply.github.com>
jacomago
force-pushed
the
cf_restart_test
branch
from
e497561 to
660e9b7
Compare
anderslindho
approved these changes
Oct 29, 2025
jacomago
force-pushed
the
cf_restart_test
branch
3 times, most recently
from
d4d763a to
718b7d4
Compare
jacomago
force-pushed
the
cf_restart_test
branch
from
718b7d4 to
8fc1c74
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.