Move an IOC to another host test #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacomago
requested review from
anderslindho,
domonkos-ess,
georgweiss,
imretoth-ess,
shroffk,
simon-ess and
tynanford
anderslindho
approved these changes
Nov 11, 2025
server/tests/docker.py
Outdated
| sleep_time=10, | ||
| ) -> str: | ||
| container_id = container_id or compose.get_container(host_name).ID | ||
| if container_id: |
Contributor
There was a problem hiding this comment.
Generally prefer inverting these:
if not container_id:
raise Exception()
# all the other stuff
🔧
server/tests/docker.py
Outdated
| time.sleep(sleep_time) | ||
| container.remove() | ||
| docker_client.containers.run( | ||
| image, detach=True, environment={"IOC_NAME": host_name}, hostname=new_host_name, network=list(networks)[0] |
Contributor
There was a problem hiding this comment.
Doesn't matter hugely in this context (due to small nbr of entities), but prefer next(iter(sequence)) over list(sequence)[0] 🔧
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.