Remove things tests #126

jacomago · 2025-11-11T14:48:03Z

Tests for

Removing a channel
Removing an alias

anderslindho

Please reconsider the commit structure or expand the commit messages a bit

simon-ess · 2025-11-12T13:22:55Z

client/demoApp/Db/test_remove_infotag.db

+record(longout, "$(P)lo:base_pv2") {
+  info("test", "testing")
+  info("hello", "world")
+  info("archive", "default")
+}


This is a somewhat confusing change on its own because it really doesn't look like you're removing an infotag, but the point I guess is that since you have added the PV to the base .db file you need it here as well.

It might be nice if there were a better way to manage this, but shrug. Maybe something with dbLoadTemplate, or one file per record?

Agree - I think one record per file might help here

Could also template startup scripts, which then further could "automate" getting record counts (as each dbLoadTemplate would be +=1)

But maybe too much indirection - not sure

client/.gitignore

anderslindho

I think the names - of startup scripts, db files, records - all are a bit confusing. What is "base"? Why do you sometimes use the term "pv" and sometimes "record"? What even is a base record - are you claming that the collection of "test", "hello", "archive" info-tags with those values are the base of the setup? (Then why is ai:base_pv different?)

I also think a refactoring along what @simon-ess suggested would make sense, to have one record per db file. I would take it further and template startup scripts in the test file where they are relevant, and I might even define the db-files in the same manner (using tmp path/dir fixtures).

client/iocBoot/iocdemo/st_base.cmd

anderslindho · 2025-11-13T06:52:50Z

server/tests/test_bash_ioc.py

+        # Act
+        restart_ioc(docker_ioc, cf_client, base_channel_name, "st_remove_infotag")

+        # Assert


This commit is a nice change, but I'd say it's a matter of factoring out start and restart functions 🔧

server/tests/client_checks.py

anderslindho · 2025-11-13T06:54:57Z

server/tests/test_multiple_recceiver.py

    def test_number_of_aliases_and_alais_property(self, cf_client: ChannelFinderClient) -> None:
        channels = cf_client.find(property=[("alias", "*")])
-        assert len(channels) == 8
+        assert len(channels) == IOC_COUNT * BASE_ALIAS_COUNT


Can squash this commit with previous

anderslindho · 2025-11-13T06:58:40Z

client/demoApp/Db/test_remove_infotag.db

+record(longout, "$(P)lo:base_pv2") {
+  info("test", "testing")
+  info("hello", "world")
+  info("archive", "default")
+}


Agree - I think one record per file might help here

Could also template startup scripts, which then further could "automate" getting record counts (as each dbLoadTemplate would be +=1)

But maybe too much indirection - not sure

server/tests/test_bash_ioc.py

tynanford · 2025-11-19T20:54:49Z

We still have the issue with flaky test failures. I assume the 3.9 and 3.12 tests will pass if we re-run them a couple of times. Doesn't have to be part of this PR but I wonder if we could change the port allocation to be a random port in cf-compose.yml

ports:
  - "0:8080"

And then if the get_service_host_and_port call in client_checks.py works like it sounds, it will create cf_client with the port docker assigned it?

ERROR    testcontainers.compose.compose:compose.py:467 STDERR:
 recc1  Built
 ioc1-1  Built
 Container test-single-ioc-elasticsearch-1  Running
 Container test-single-ioc-elasticsearch-1  Waiting
 Container test-single-ioc-elasticsearch-1  Healthy
 Container test-single-ioc-cf-1  Starting
Error response from daemon: failed to set up container networking: driver failed programming external connectivity on endpoint test-single-ioc-cf-1 (8fa9cb4b3ba67cc61319d41a149350d1860d683fbab0bdd888cdb9cedeceb083): Bind for 0.0.0.0:8080 failed: port is already allocated

Or maybe the containers just need to be torn down at the end of each test?

jacomago · 2025-11-20T10:07:47Z

We still have the issue with flaky test failures. I assume the 3.9 and 3.12 tests will pass if we re-run them a couple of times. Doesn't have to be part of this PR but I wonder if we could change the port allocation to be a random port in cf-compose.yml
ports:
  - "0:8080" 
And then if the get_service_host_and_port call in client_checks.py works like it sounds, it will create cf_client with the port docker assigned it?
ERROR    testcontainers.compose.compose:compose.py:467 STDERR:
 recc1  Built
 ioc1-1  Built
 Container test-single-ioc-elasticsearch-1  Running
 Container test-single-ioc-elasticsearch-1  Waiting
 Container test-single-ioc-elasticsearch-1  Healthy
 Container test-single-ioc-cf-1  Starting
Error response from daemon: failed to set up container networking: driver failed programming external connectivity on endpoint test-single-ioc-cf-1 (8fa9cb4b3ba67cc61319d41a149350d1860d683fbab0bdd888cdb9cedeceb083): Bind for 0.0.0.0:8080 failed: port is already allocated
Or maybe the containers just need to be torn down at the end of each test?

They should be torn down between each test class already. I think this problem is them not tearing down fast enough. I will try random port in another PR.

The previous flakyness I used to see was the docker machine not being ready at the time the tests started, which I'm less sure on how to fix as its from the github actions os.

server/tests/client_checks.py

server/tests/test_bash_ioc.py

sonarqubecloud · 2025-11-26T12:51:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jacomago · 2025-12-04T09:41:12Z

We still have the issue with flaky test failures. I assume the 3.9 and 3.12 tests will pass if we re-run them a couple of times. Doesn't have to be part of this PR but I wonder if we could change the port allocation to be a random port in cf-compose.yml
ports:
  - "0:8080" 
And then if the get_service_host_and_port call in client_checks.py works like it sounds, it will create cf_client with the port docker assigned it?
ERROR    testcontainers.compose.compose:compose.py:467 STDERR:
 recc1  Built
 ioc1-1  Built
 Container test-single-ioc-elasticsearch-1  Running
 Container test-single-ioc-elasticsearch-1  Waiting
 Container test-single-ioc-elasticsearch-1  Healthy
 Container test-single-ioc-cf-1  Starting
Error response from daemon: failed to set up container networking: driver failed programming external connectivity on endpoint test-single-ioc-cf-1 (8fa9cb4b3ba67cc61319d41a149350d1860d683fbab0bdd888cdb9cedeceb083): Bind for 0.0.0.0:8080 failed: port is already allocated
Or maybe the containers just need to be torn down at the end of each test?

Think I will try this now....

jacomago force-pushed the remove-things-tests branch 4 times, most recently from 82a4f6a to efe0345 Compare November 12, 2025 09:25

jacomago self-assigned this Nov 12, 2025

jacomago force-pushed the remove-things-tests branch 2 times, most recently from 078c923 to 6ff043e Compare November 12, 2025 12:10

jacomago marked this pull request as ready for review November 12, 2025 12:32

jacomago requested review from anderslindho, domonkos-ess, georgweiss, imretoth-ess, mdavidsaver, ralphlange, shroffk, simon-ess and tynanford November 12, 2025 12:32

anderslindho reviewed Nov 12, 2025

View reviewed changes

jacomago force-pushed the remove-things-tests branch from 6ff043e to 638a14a Compare November 12, 2025 13:19

simon-ess reviewed Nov 12, 2025

View reviewed changes

jacomago requested a review from anderslindho November 12, 2025 14:32

tynanford reviewed Nov 12, 2025

View reviewed changes

client/.gitignore Show resolved Hide resolved

anderslindho reviewed Nov 13, 2025

View reviewed changes

jacomago mentioned this pull request Nov 13, 2025

Refactor docker ioc used in testing recceiver #127

Merged

jacomago force-pushed the remove-things-tests branch 3 times, most recently from 5c66ef3 to 3f8cd76 Compare November 17, 2025 14:50

jacomago requested review from anderslindho, simon-ess and tynanford November 17, 2025 15:06

tynanford reviewed Nov 17, 2025

View reviewed changes

server/tests/test_bash_ioc.py Outdated Show resolved Hide resolved

jacomago added 7 commits November 19, 2025 10:13

Split up test_remove_infotag

9da46b7

Extract BASE_IOC_CHANNEL_COUNT

45ddf49

Extract BASE_ALIAS_COUNT

fcf6c08

Add a test remove channel

6e47a9e

Test removing an alias

4fa3bd2

fixup! Add a test remove channel

682b580

fixup! Split up test_remove_infotag

393ef9b

jacomago force-pushed the remove-things-tests branch from 35af100 to 393ef9b Compare November 19, 2025 09:13

anderslindho reviewed Nov 20, 2025

View reviewed changes

server/tests/client_checks.py Outdated Show resolved Hide resolved

server/tests/test_bash_ioc.py Outdated Show resolved Hide resolved

server/tests/test_bash_ioc.py Outdated Show resolved Hide resolved

server/tests/test_bash_ioc.py Outdated Show resolved Hide resolved

jacomago added 4 commits November 25, 2025 13:54

clearer count constants

ca08bfe

Add assert message

81bee97

remove unused ignore lint

c95028c

More descriptive assert on TEST_INFO_TAG

638e6fb

anderslindho approved these changes Nov 27, 2025

View reviewed changes

jacomago merged commit 466a55d into ChannelFinder:master Nov 27, 2025
18 checks passed

Remove things tests #126

Remove things tests #126

Uh oh!

Conversation

jacomago commented Nov 11, 2025

Uh oh!

anderslindho left a comment

Choose a reason for hiding this comment

Uh oh!

simon-ess Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

anderslindho Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anderslindho left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anderslindho Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anderslindho Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

anderslindho Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tynanford commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacomago commented Nov 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Nov 26, 2025

Quality Gate passed

Uh oh!

Uh oh!

jacomago commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tynanford commented Nov 19, 2025 •

edited

Loading