refactor(buy-nft-modal): improve UX, safety, and accessibility#2
Open
syed-ghufran-hassan wants to merge 1 commit intoChaoLing140:feature/issue-43-dispute-resolutionfrom
Open
Conversation
syed-ghufran-hassan
commented
Feb 26, 2026
syed-ghufran-hassan
commented
- Added local isSubmitting state to prevent double purchases
- Wrapped onConfirm in try/catch to handle async errors safely
- Memoized derived values (price, balance, seller)
- Added image fallback and error handler
- Prevented modal close while transaction is processing
- Improved accessibility (aria-busy, aria-disabled, role="alert")
- Added defensive handling for missing seller/description
- Added local isSubmitting state to prevent double purchases - Wrapped onConfirm in try/catch to handle async errors safely - Memoized derived values (price, balance, seller) - Added image fallback and error handler - Prevented modal close while transaction is processing - Improved accessibility (aria-busy, aria-disabled, role="alert") - Added defensive handling for missing seller/description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.