Fix containers being openable after destroyed

[democat3457]

Implements the fix stated on https://www.curseforge.com/minecraft/mc-mods/containerfix.

This PR fixes the fact that if you remain in a container's inventory after the container gets destroyed, you don't get booted out of the GUI by adding a check for if the tile entity at that location is still present.

[copygirl]

This doesn't check the distance, does it?

[democat3457]

no, but I just tested it, and the GUI was uninteractable after moving farther away using a minecart - would the (possibly redundant) distance check still be useful to put in regardless?

[asiekierka]

Shouldn't the container's tile entity be invalidated?

[democat3457]

Shouldn't the container's tile entity be invalidated?

what do you mean? the method doesnt check anything on containerHandler regarding whether it still exists, and the bug definitely exists before this pull request - and the only null check that exists will still return true if the player is the te owner

[asiekierka]

isOwnerPresent() should be calling the TileEntity's isInvalid() method.

[democat3457]

Hmm it must be that the TileEntity is never getting invalidate() called when destroyed

[asiekierka]

It might be that it doesn't propagate to the client side.

[democat3457]

@asiekierka Could this get merged anyway? It theoretically should be redundant if the invalidate() behavior worked properly, but the bug still exists, and this works as a patch in the meantime.