Remove hardcoded paths from setup#4
Open
TimFerrell wants to merge 1 commit intoChaseDurand:masterfrom
Open
Conversation
Owner
|
Hi Tim! Thank you for this contribution. I like the fix for accounting for different user names by getting and using $parent_path, but am confused why pushd and popd are used; it seems like all of the commands use absolute path names and don't require changing directories. Are these commands necessary? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your work on this project @ChaseDurand! Looks great.
Ran into a small issue on setup in that I had a different user than what was defined in your original setup file. With this change, you're
pushd'd into the setup directory where the setup is executed and thenpopd'd back to your original directory on completion.