Trading signal Skill from Binance

[markusha77]

New Skill Contribution

Skill Info

• Skill ID: trading-signal
• Category: Blockchain
• Description: Retrieve on-chain smart money trading signals, including buy or sell direction, trigger and current price, max gain, exit rate, and token tags.

Checklist

• SKILL.md has valid YAML frontmatter with all required fields
• Skill ID matches the directory name
• Category is one of: productivity, development, communication, writing, research, other
• Instructions are clear and self-contained
• Instructions are under 4000 tokens
• No external URLs referenced in instructions
• Tested the skill with an AI agent and it produces good results
• Added usage examples in the frontmatter

Testing

Describe how you tested this skill:

Notes

Any additional context or notes for reviewers.

[greptile-apps]

Greptile Summary

This PR adds a new trading-signal skill that instructs an AI agent how to fetch and present on-chain Smart Money trading signals from the Binance Web3 API. The skill documents the POST endpoint, request/response schema, supported chains (BSC and Solana), signal statuses, and token tag categories in detail.

Issues found:

• Blocking — Invalid category: The frontmatter declares category: Blockchain, which is not one of the six permitted values (productivity, development, communication, writing, research, other) defined in CONTRIBUTING.md. This will cause the automated PR validation to fail. The category should be changed to other or research.
• Blocking — External URLs present: CONTRIBUTING.md explicitly forbids referencing external URLs in skill instructions ("Skills should be self-contained"). The skill embeds the live Binance API URL (https://web3.binance.com/...) and a CDN base URL (https://bin.bnbstatic.com) multiple times throughout the body. The PR checklist item for this was incorrectly marked as done.
• Not tested: The author left the "Tested the skill with an AI agent and it produces good results" checkbox unchecked. While not a hard blocker, it indicates the skill's quality has not been verified end-to-end.

Confidence Score: 1/5

• Not safe to merge — two blocking issues (invalid category and external URLs) must be resolved first.
• The skill has two issues that directly violate the contribution guidelines documented in CONTRIBUTING.md: an invalid category value that will fail automated validation, and embedded external URLs that break the self-contained requirement. The skill is also untested by the author. The content and structure of the skill itself are otherwise clear and well-documented.
• skills/trading-signal/SKILL.md — invalid category and external URL violations must be addressed before merging.

Important Files Changed

Filename	Overview
skills/trading-signal/SKILL.md	New skill file documenting Binance Smart Money trading signal API. Has two blocking issues: (1) invalid category: Blockchain (must be one of the six allowed values), and (2) multiple external URLs embedded in the instructions, which violates the contribution guidelines. The skill was also not tested by the author per the PR checklist.

Sequence Diagram

sequenceDiagram
    participant User
    participant Agent as AI Agent (Skill)
    participant Binance as Binance Web3 API

    User->>Agent: "Show latest smart money buy signals on Solana"
    Agent->>Binance: POST /signal/smart-money\n{chainId: "CT_501", page: 1, pageSize: 100}
    Binance-->>Agent: {code: "000000", data: [...signals]}
    Agent->>Agent: Parse signals\n(direction, alertPrice, currentPrice,\nmaxGain, exitRate, status, tokenTag)
    Agent-->>User: Formatted signal summary\n(buy/sell, price comparison, max gain, exit rate, tags)

    User->>Agent: "Get BSC signals ranked by max gain"
    Agent->>Binance: POST /signal/smart-money\n{chainId: "56", page: 1, pageSize: 100}
    Binance-->>Agent: {code: "000000", data: [...signals]}
    Agent->>Agent: Sort by maxGain descending
    Agent-->>User: Ranked signal list with performance data

Loading

_{Last reviewed commit: "add Trading Signal S..."}

[greptile-apps]

Invalid category value

The frontmatter uses category: Blockchain, but according to CONTRIBUTING.md, the only valid values are: productivity, development, communication, writing, research, other.

The automated PR checks explicitly validate that "Category is valid", so this skill will fail the automated review pipeline and cannot be merged as-is. For a financial data/on-chain analytics skill, research or other would be the most appropriate choices.

Suggested change

	category: Blockchain
	category: other

[greptile-apps]

External URLs violate contribution guidelines

CONTRIBUTING.md explicitly states: "Don't reference external URLs — Skills should be self-contained."

However, this skill contains multiple live external URLs throughout its body:

• Line 33: https://web3.binance.com/bapi/defi/v1/public/wallet-direct/buw/wallet/web/signal/smart-money (repeated on lines 62, 219, 227)
• Line 81: https://bin.bnbstatic.com/image/... (inside the example JSON)
• Line 235: https://bin.bnbstatic.com (in the Notes section)

The PR checklist item "No external URLs referenced in instructions" was checked as done, but this is incorrect — the skill contains several external URLs. These references also create a maintenance risk: if the Binance API endpoint path or the CDN URL changes, the skill instructions will become inaccurate.

Consider replacing the live API URL with a placeholder (e.g., {BINANCE_WEB3_API_BASE_URL}/signal/smart-money) and referencing the CDN domain abstractly, or working with the maintainers to confirm whether API-endpoint-style skills have an exemption from this rule.