Conversation
Greptile SummaryThis PR adds a new Issues found:
Confidence Score: 2/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Agent as AI Agent
participant API1 as Binance API 1<br/>(Meme Rush – POST)
participant API2 as Binance API 2<br/>(Topic Rush – GET)
Note over Agent: User asks for meme token tracking
Agent->>API1: POST /pulse/rank/list<br/>{ chainId, rankType, [filters] }
API1-->>Agent: { data: { tokens[] } }<br/>Core fields, holder %, dev info, tags, socials
Note over Agent: User asks for hot narrative topics
Agent->>API2: GET /social-rush/rank/list<br/>?chainId=&rankType=&sort=&[filters]
API2-->>Agent: { data[] }<br/>Topic fields + tokenList[] per topic
Note over Agent: Format response<br/>Append % to pre-formatted fields<br/>Prefix icon URLs with https://bin.bnbstatic.com
Last reviewed commit: "add Meme Rush skill ..." |
| | sort | integer | Sort by: `10`=create time, `20`=net inflow, `30`=viral time | | ||
|
|
||
| > **Sort convention**: When the user does not specify a sort preference, use `sort=10` (create time) for Latest/Rising, and `sort=30` (viral time) for Viral. |
There was a problem hiding this comment.
sort marked required but Note 1 contradicts this
API 2 lists sort as a Required Parameter alongside chainId and rankType, but Note 1 at line 342 states: "Only chainId and rankType are required; all other parameters are optional filters."
An AI agent following this skill will receive conflicting instructions: should it always send sort, or is it optional? If sort truly has a default server-side behavior when omitted, it should be moved to the Optional Parameters table. If it is genuinely required, Note 1 needs to be updated to reflect that.
| | sort | integer | Sort by: `10`=create time, `20`=net inflow, `30`=viral time | | |
| > **Sort convention**: When the user does not specify a sort preference, use `sort=10` (create time) for Latest/Rising, and `sort=30` (viral time) for Viral. | |
| | chainId | string | Chain ID: `56`, `CT_501` | | |
| | rankType | integer | `10`=Latest, `20`=Rising, `30`=Viral | |
And move sort to the Optional table with a default-value note, or correct Note 1 to say "Only chainId and rankType are required for API 1; API 2 additionally requires sort."
| | Filter | Type | Description | | ||
| |--------|------|-------------| | ||
| | progressMin/Max | string | Bonding curve progress (0-100%) | | ||
| | tokenAgeMin/Max | long | Token age | |
There was a problem hiding this comment.
tokenAgeMin/Max unit is unspecified
The tokenAgeMin/Max filter is documented as type long but gives no indication of what unit should be used (seconds, milliseconds, minutes?). Compared with migrateTime and createTime in the response section which are explicitly noted as (ms), this omission could cause an AI agent to construct incorrect filter values.
| | tokenAgeMin/Max | long | Token age | | |
| | tokenAgeMin/Max | long | Token age in milliseconds | |
| |-------|------|-------------| | ||
| | protocol | integer[] | Launchpad protocol codes (see Protocol Reference) | | ||
| | exclusive | integer | Binance exclusive token: `0`=no, `1`=yes | | ||
| | paidOnDexScreener | integer | Paid on DexScreener | |
There was a problem hiding this comment.
paidOnDexScreener filter missing valid values
Every similar boolean/flag filter in this table explicitly documents its accepted values (e.g., pumpfunLiving: 1=yes, cmcBoost: 1=yes, exclusive: 0=no, 1=yes), but paidOnDexScreener has no value description. An AI agent will have no way to know what value to send to enable or disable this filter.
| | paidOnDexScreener | integer | Paid on DexScreener | | |
| | paidOnDexScreener | integer | Paid on DexScreener: `1`=yes | |
| id: meme-rush | ||
| name: Meme Rush | ||
| description: Fast meme-token market tracking for launch lifecycle and hot-topic narratives, with filters for migration, holders, and net inflow. | ||
| category: Blockchain |
There was a problem hiding this comment.
The frontmatter sets category: Blockchain, but the contribution checklist explicitly lists the allowed values as: productivity, development, communication, writing, research, other. Blockchain is not in this list and will likely cause validation to fail for this skill submission.
| category: Blockchain | |
| category: other |
New Skill Contribution
Skill Info
Checklist
Testing
Describe how you tested this skill:
Notes
Any additional context or notes for reviewers.