Skip to content

chore: Fix/dependabot and ci#64

Merged
anchildress1 merged 5 commits intomainfrom
fix/dependabot-and-ci
Feb 24, 2026
Merged

chore: Fix/dependabot and ci#64
anchildress1 merged 5 commits intomainfrom
fix/dependabot-and-ci

Conversation

@anchildress1
Copy link
Copy Markdown
Member

@anchildress1 anchildress1 commented Feb 24, 2026

This pull request includes several configuration and script updates aimed at improving workflow consistency, error handling, and dependency management. The most important changes are grouped below by theme.

Workflow and Dependency Management:

  • Changed the dependency installation step in .github/workflows/security-ci.yml to use uv lock instead of uv sync --locked --group dev, ensuring a more consistent lock file generation.
  • Updated the commit message prefix for Dependabot updates from "deps" and "deps-dev" to "chore" in .github/dependabot.yml, standardizing commit message conventions.

Script Error Handling:

  • Modified the cleanup() and main() functions in .specify/scripts/bash/update-agent-context.sh to use return instead of exit, improving error handling and script composability. [1] [2]

Release Configuration:

  • Moved the include-component-in-tag property from the root to the package-specific section in release-please-config.json, clarifying configuration scope and ensuring proper tagging behavior for the Python package.

anchildress1 and others added 5 commits February 23, 2026 18:47
Replace non-standard deps/deps-dev prefixes with chore so dependabot
produces valid conventional commits: chore(deps): and chore(deps-dev):

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Run uv lock before make install so the lockfile is always consistent
with pyproject.toml, preventing --locked failures on dependabot PRs.
Also removes the redundant direct uv sync that duplicated make install.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The packages/manifest setup forces monorepo component semantics even
for a single package. Switch to simple (non-manifest) mode — version
tracking continues from the existing v1.0.0 tag. The manifest file is
no longer referenced and can be ignored.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace exit with return in cleanup() and main() so all functions have
explicit return statements, satisfying Sonar rule S6596.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The setting was at the top level but only takes effect per-package in
manifest mode. Keep manifest-file explicit and packages structure intact.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings February 24, 2026 00:41
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates automation configuration (Dependabot, CI, Release Please) and improves the composability of an internal bash script used for updating agent context files.

Changes:

  • Adjust Dependabot commit message prefixing to align with conventional commits.
  • Modify security CI dependency setup to use uv lock before running make install.
  • Simplify release-please-config.json by consolidating settings under the packages entry and adjust script exit/return behavior in update-agent-context.sh.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
release-please-config.json Moves include-component-in-tag under the . package configuration.
.specify/scripts/bash/update-agent-context.sh Switches exit to return in cleanup and main for better composability.
.github/workflows/security-ci.yml Changes dependency step to run uv lock before make install.
.github/dependabot.yml Updates Dependabot commit message prefix to chore.
Comments suppressed due to low confidence (1)

.specify/scripts/bash/update-agent-context.sh:124

  • cleanup is registered for INT/TERM as well as EXIT, but it now uses return. For INT/TERM, returning from the trap handler suppresses the default signal behavior and the script will continue running after Ctrl+C / termination signals. If the goal is to avoid killing the parent shell when sourced, consider conditionally exit when executed directly and return when sourced (or keep exit for INT/TERM and only return for EXIT).
cleanup() {
    local exit_code=$?
    rm -f /tmp/agent_update_*_$$
    rm -f /tmp/manual_additions_$$
    return $exit_code
}

# Set up cleanup trap
trap cleanup EXIT INT TERM

run: |
echo "## 🔧 Installing dependencies" >> "$GITHUB_STEP_SUMMARY"
uv sync --locked --group dev
uv lock
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uv lock generates/updates uv.lock but does not install dependencies. In CI this makes the environment non-reproducible (it can resolve newer versions than what’s committed) and is redundant since make install already runs uv sync --locked --group dev. Prefer removing uv lock here, or replace it with a non-mutating validation like uv lock --locked if you want to assert the lockfile is up to date.

Suggested change
uv lock

Copilot uses AI. Check for mistakes.
@anchildress1 anchildress1 merged commit bcb8096 into main Feb 24, 2026
9 checks passed
@anchildress1 anchildress1 deleted the fix/dependabot-and-ci branch February 24, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants