Open
Conversation
Collaborator
TimotheusBachinger
commented
Apr 11, 2024
- Bump bazel version to 7.1.1
- Switch toolchain to gcc 13.2.0 + glibc 2.22
22f1a79 to
0d315a5
Compare
Use: bazel build --sandbox_add_mount_pair=/tmp --sandbox_debug --verbose_failures --platforms=//platforms:x86_64_linux //examples/rrdtool:rrdtool
Synss
reviewed
Apr 23, 2024
| "--disable-tcl", | ||
| "--with-systemdsystemunitdir=no", | ||
| # https://github.com/bazelbuild/rules_foreign_cc/issues/239 | ||
| "CFLAGS='-Dredacted=\"redacted\"'", |
Collaborator
There was a problem hiding this comment.
I think that doesn't append but replaces the CFLAGS.
However, Bazel passes the include directories to the compiler with CFLAGS=-isystem .... Replacing CFLAGS means no header is found and configure fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.