added windows notification feature to tell the result of the search, … #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added icon and a schedulaer for the next search. the scheduler is set to 5 seconds by default
Chelsea31
reviewed
Oct 19, 2021
| import time | ||
|
|
||
| from bs4 import BeautifulSoup | ||
| from win10toast import ToastNotifier |
Owner
There was a problem hiding this comment.
Please remove the duplicate import
Chelsea31
reviewed
Oct 19, 2021
| requests==2.22.0 | ||
| beautifulsoup4~=4.9.3 | ||
| beautifulsoup4~=4.9.3 | ||
| win10toast |
Owner
There was a problem hiding this comment.
- Its always a good practice to have the version in the requirements, its possible libraries introduce breaking changes in newer versions which might break the application.
- win10toast is a windows binary, so I am not even able to run this code on a mac, you can add something like this
win10toast==0.9; platform_system == "Windows", which would only install this on windows devices
Owner
|
Thank you for the PR @AdetonaMichael! |
Chelsea31
requested changes
Oct 19, 2021
Owner
Chelsea31
left a comment
Chelsea31
left a comment
There was a problem hiding this comment.
Changes are requested for making code agnostic of OS, or even inclusive of all OS
You can have toaster notification for windows, and just leave a simple print for other OS's
I am eager to see what you come up with! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and Issues/PRs
None
What does this implement/fix? (Changes)
Any other comments?
No