Issue #21: Add unit test to authSignupController for existing user scenario #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SignupController.test.js for clarity
AbhinavReddy-Dev
previously approved these changes
Mar 14, 2023
sourabhk25
previously approved these changes
Mar 15, 2023
Contributor
sourabhk25
left a comment
sourabhk25
left a comment
There was a problem hiding this comment.
All looks good to me.
Code executed on my local machine -
Contributor
|
This PR seems improperly labelled. It does not address #21, instead, #21 seems like a prerequisite for it. #21 simply configures testing to work on the project, it isn't all-encompassing of all-things-testing. However, it does need to be completed and accepted before any other testing code (such as this PR) is committed. Consequently, if this is accepted (either now or in the future), it should be Squashed to replace references to #21 with its real purpose: testing |
chetan2298
dismissed stale reviews from sourabhk25 and AbhinavReddy-Dev
via
4bd9ad5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainbranchmainalong with a status badge inREADME.md