Merged
Conversation
Contributor
|
Can you add an image with the result? |
Contributor
Author
sorry, I don't understand you. like you mean it should be able to upload image ? |
Contributor
|
No, like a screenshot of the page that you created |
Contributor
Author
|
Okay
I will do that soon
I'm on transit now
…On Fri, 21 Feb 2025, 16:36 Josue Sandino, ***@***.***> wrote:
No, like a screenshot of the page that you created
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAYCM7BSASFAGIRTNIKEYJL2Q5BXNAVCNFSM6AAAAABXSLZYFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZUHA3TCOBYGI>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
[image: jsandinoDev]*jsandinoDev* left a comment
(Chonete-Builders/CryptoHack-AI#21)
<#21 (comment)>
No, like a screenshot of the page that you created
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAYCM7BSASFAGIRTNIKEYJL2Q5BXNAVCNFSM6AAAAABXSLZYFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZUHA3TCOBYGI>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Contributor
Author
|
This is a video of the result : |
Contributor
Author
|
Hello @jsandinoDev |
Ilialtes
requested changes
Feb 24, 2025
| const newIdea = { | ||
| name: "Idea Name", | ||
| image: "", | ||
| description: `Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.\n\nLorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.`, |
Contributor
There was a problem hiding this comment.
Move this constants into a constants file , also please use the naming convention for constants NEW_IDEA
| </div> | ||
| </div> | ||
|
|
||
| <div className="w-full max-w-[1057px] flex-col md:flex-row gap-4 flex items-center justify-between p-1"> |
Contributor
There was a problem hiding this comment.
Create a reusable section card instead of repeating the code for the description, impact and uniqueness
import React from 'react';
const SectionCard = ({ title, content }) => {
return (
<div className="bg-[#F5F5F5] w-full rounded-[50px] p-4 flex flex-col gap-2">
<h2 className="text-[#2C2C2C] text-base font-semibold ml-5">{title}</h2>
<div className="bg-white p-4 border border-[#D9D9D9] rounded-[10px] overflow-y-auto scrollbar-hide">
<p className="text-[#1E1E1E] font-normal text-base leading-[22.4px] whitespace-pre-line">
{content}
</p>
</div>
</div>
);
};
export default SectionCard;
| </div> | ||
|
|
||
| <div className="flex flex-row md:flex-col items-center justify-center gap-7 md:ml-auto"> | ||
| <button className="bg-[#2C2C2C] text-white w-[108px] h-[32px] rounded-[8px]">Share</button> |
Contributor
There was a problem hiding this comment.
add placeholder functions for the buttons:
onClick={() => console.log('Share clicked')}).
Created a reusable card Add placeholder onclick function for the buttons
Contributor
Author
|
close #6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #6
Created the new idea screen
Though I noticed some build errors in other files, let me know if I should fix it.