Skip to content

Add signature replay, fix single-node startup, change log statements #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tschuyebuhl wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add signature replay, fix single-node startup, change log statements #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eafa2af
Add signature replay, fix node startup, fix log statements
tschuyebuhl Mar 4, 2026
1a84d05
Remove outdated entry about the signature cache
tschuyebuhl Mar 6, 2026
6a8ed85
sign votes even if vote extensions don't match
tschuyebuhl Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ raft-proto = { version = "0.7.0", features = ["prost", "protobuf-codec"] }
slog-stdlog = "4.1.1"
protobuf = "2.28.0"
byteorder = "1.5.0"
enum_dispatch = "0.3.13"
clap = { version = "4.5.45", features = ["derive"] }
sha2 = "0.10.9"
[build-dependencies]
Expand Down
1 change: 0 additions & 1 deletion src/backend/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ mod tests {
use crate::backend::Bls12381Signer;
use crate::backend::SigningBackend;
use base64::{Engine as _, engine::general_purpose};
use hex;

#[test]
fn bls12381_sign_known_data() {
Expand Down
5 changes: 2 additions & 3 deletions src/backend/vault_signer_plugin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
use crate::error::SignerError;
use hex;
use log::{debug, info, trace};
use log::{info, trace};
use reqwest::blocking::{Client, ClientBuilder};
use reqwest::header::{HeaderMap, HeaderValue};
use serde_json::Value;
Expand Down Expand Up @@ -167,7 +166,7 @@ impl PluginVaultSigner {
let sig_bytes =
base64::Engine::decode(&base64::engine::general_purpose::STANDARD, parts[2])?;

debug!("signed bytes from vault: {:?}", sig_bytes);
trace!("signed bytes from vault: {:?}", sig_bytes);

let expected_sig_len = match self.pub_key.key_type {
crate::types::KeyType::Ed25519 => 64,
Expand Down
Loading