fix crash if curved rail has no items_to_place_this#110
Open
daviscook477 wants to merge 1 commit intoChoumiko:masterfrom
Open
fix crash if curved rail has no items_to_place_this#110daviscook477 wants to merge 1 commit intoChoumiko:masterfrom
daviscook477 wants to merge 1 commit intoChoumiko:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when checking "straight-rail" there is a check on "proto.items_to_place_this" before then trying to use pairs on "proto.items_to_place_this"
however when checking "curved-rail" there is no check on "proto.items_to_place_this" before then trying to use pairs on "proto.items_to_place_this"
this means that when another mod adds a type of rail for which there is no item to place it, FARL crashes with the following error:
this PR adds the missing check to the "curved-rail" line