Force SSL version 1 to accomodate SOLUS' bad handshake. (Fixes #88)

[sidequestboy]

Quick fix to #88 involves subclassing HTTPAdapter to specify ssl_version (currenlty hard-coded to ssl.PROTOCOL_TLSv1)

[uniphil]

This works and looks great from my end. Any thoughts @pR0Ps @ChrisCooper?

If I was really picky I'd say the SSL import should come first, then the requests imports, then the other qcumber parser stuff.

[pR0Ps]

I haven't had time to re-setup my dev environment yet so I can't verify at the moment, but from just looking at the code, it looks good.

[mystor]

I can try this later, it will be useful for when I am trying changes to #90 to make it more relational.
I can't try it out right now (Gael here, very very busy), but I will be able to possibly next week.

[ChrisCooper]

Excellent! Thanks again @Jameh :)

Ok, I'll be picky too according to Phil. Do you mind moving those imports up nearer to the top? We've been pseudo following the convention of importing external stuff first, then Qcumber stuff, just to keep things organized (Qcumber imports change more frequently as well). Then I'll happily merge!

[sidequestboy]

Here you go :)

[sidequestboy]

is the new commit acceptable?

[ChrisCooper]

Sorry, yep!

On Thu, Sep 5, 2013 at 2:15 AM, jameh notifications@github.com wrote:

is the new commit acceptable?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/92#issuecomment-23845890
.

[ChrisCooper]

Thanks again! :)