Added the option to clear the existing devices in the discover method so the whole scan process can start again from the begining.#18
Open
sidequestlegend wants to merge 1 commit intoChrisScheffler:masterfrom
Conversation
… so the whole scan process can start again from the begining.
I was attempting to use miflora in a custom node in node-red. When it re-deploys a node it will re-run all the code and I was having trouble tearing down the miflora connection and it would break on each deploy until I restarted node-red. I discovered this was due to the main miflora devices object was not reset between calls to the `discover` method so the same device was never discovered again and it seemed to break things. This commit hopefully solves that. Here is some code demonstrating the problem:
```
const miflora = require('miflora');
const opts = {
duration: 60000,
ignoreUnknown: true,
addresses: ['c4:7c:8d:66:23:b5']
};
(async () => {
console.log('attempt 1')
let device = (await miflora.discover(opts))[0];
await device.querySensorValues();
await device.disconnect();
console.log('done attempt 1');
miflora._devices = {}; // Without this line the below would fail to find the device.
console.log('attempt 2')
device = (await miflora.discover(opts))[0];
await device.querySensorValues();
await device.disconnect();
console.log('done attempt 2');
})();
```
This PR adds an option `clearDevices` to the options passed to the discover method to that the above would become:
```
const miflora = require('miflora');
const opts = {
duration: 60000,
ignoreUnknown: true,
clearDevices: true,
addresses: ['c4:7c:8d:66:23:b5']
};
(async () => {
console.log('attempt 1')
let device = (await miflora.discover(opts))[0];
await device.querySensorValues();
await device.disconnect();
console.log('done attempt 1');
console.log('attempt 2')
device = (await miflora.discover(opts))[0];
await device.querySensorValues();
await device.disconnect();
console.log('done attempt 2');
})();
```
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was attempting to use miflora in a custom node in node-red. When it re-deploys a node it will re-run all the code and I was having trouble tearing down the miflora connection and it would break on each deploy until I restarted node-red. I discovered this was due to the main miflora devices object was not reset between calls to the
discovermethod so the same device was never discovered again and it seemed to break things. This commit hopefully solves that. Here is some code demonstrating the problem:This PR adds an option
clearDevicesto the options passed to the discover method to that the above would become:Thank you!