Merged
Conversation
Removed conditional check for RORG.MSC and updated comment.
Pull Request Test Coverage Report for Build 21483484380Details
💛 - Coveralls |
Added test for creating RadioPacket with MSC parameters.
Added a print statement to output serialized packet data during the test.
Refactor RadioPacket creation for better readability and maintainability.
Updated PACKET_CONTENT_5 to change specific byte values.
When parsing an EnOcean packet, if an enum value or rangeitem is not found in the EEP XML definition, the parser would raise an AttributeError because it tried to call .get() on a None object. This commit adds a robust check and a fallback to returning the raw value as a string when the description is missing. Added a regression test in enocean/protocol/tests/test_eep.py. Co-authored-by: ChristopheHD <16214389+ChristopheHD@users.noreply.github.com>
…79357758187 Fix AttributeError in EEP parser for missing enum values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChristopheHD/HA_enoceanmqtt-addon#78