Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves search query performance, adds a standalone worker binary for scaling, and fixes a bug in the delete job functionality.
- Optimized hybrid search query by removing unused window function calculations (
COUNT(*) OVER ()) - Added standalone
vectorize-workerbinary to enable independent worker scaling - Fixed PGMQ table name in job cleanup from
pgmq.vectorize_jobstopgmq.q_vectorize_jobs
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/query.rs | Simplified hybrid search query by removing redundant COUNT(*) OVER () calculations and replacing CASE WHEN with COALESCE for cleaner null handling |
| core/src/init.rs | Fixed PGMQ table name in cleanup_job to use the correct q_vectorize_jobs table |
| server/Cargo.toml | Added binary definition for the new standalone worker |
| server/Dockerfile | Added build and copy steps for the vectorize-worker binary to enable separate deployment |
| server/tests/tests.rs | Refactored test to use common helper function for table creation, reducing code duplication |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.