Conversation
- Move source files to `src/` layout. - Remove `setup.py` and `requirements.txt`. - Centralize all configurations, including `tox`, `ruff`, and `mypy` within `pyproject.toml`. - Configure testing, linting, and documentation tools in the `dev` optional dependency group. - Migrate CLI usage in `examples/mythica/model.py` from `argparse` to `click`. - Use correct pipe operator for unions and fix type hints inside the source code without using `Any`. - Update Github Actions workflow to include linting, type checks, and formatting verification. - Update pre-commit hook configs to use format, type checking and local tox testing. Co-authored-by: Ciemaar <1388496+Ciemaar@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Move source files to `src/` layout. - Remove `setup.py` and `requirements.txt`. - Centralize all configurations, including `tox`, `ruff`, and `mypy` within `pyproject.toml`. - Configure testing, linting, and documentation tools in the `dev` optional dependency group. - Migrate CLI usage in `examples/mythica/model.py` from `argparse` to `click`. - Use correct pipe operator for unions and fix type hints inside the source code without using `Any`. - Update Github Actions workflow to include linting, type checks, and formatting verification. - Update pre-commit hook configs to use format, type checking and local tox testing. Co-authored-by: Ciemaar <1388496+Ciemaar@users.noreply.github.com>
As requested in code review, this relaxes the dependencies specified in `pyproject.toml` by removing strict pin versions (e.g., `>=8.0.0` or `>=2.0.0`). Because this repository is intended as a library, dependencies should be left as unpinned as reasonably possible so that dependent projects do not suffer from version collision issues. Co-authored-by: Ciemaar <1388496+Ciemaar@users.noreply.github.com>
Enables 'W' (pycodestyle warnings) and 'I' (isort) rules in ruff configuration per PR review request and runs `ruff check --fix` to correctly sort imports across `src` and `test` directories. Co-authored-by: Ciemaar <1388496+Ciemaar@users.noreply.github.com>
1 participant
Modernizes the Python repository by centralizing configurations into
pyproject.tomland adopting ansrc/layout.src/layout.setup.pyandrequirements.txtscripts.clickin the mythica example model script.tox,pytest,mypy,ruff,mdformat) centrally within thepyproject.tomldefinition.typing.Anyortyping.Union..pre-commit-config.yamlto enforce strict formatting, typing, and local pytest validation natively.PR created automatically by Jules for task 12854738292463353026 started by @Ciemaar