Open
Conversation
- Added `glom` dependency to pyproject.toml and setup.py - Refactored `index_reference` and `attr_reference` in `closure_collector/closures.py` to build a `glom.T` based specification instead of manually traversing `index`/`getattr`. - Updated exception handling in tests (`test_closures.py`) to expect `glom.GlomError` instead of `KeyError` or `AttributeError` when there's no default. - Suppressed `glom` typing imports in `mypy` using `type: ignore` and overrides. Co-authored-by: Ciemaar <1388496+Ciemaar@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Added `glom` dependency to pyproject.toml and setup.py - Refactored `index_reference` and `attr_reference` in `closure_collector/closures.py` to build a `glom.T` based specification instead of manually traversing `index`/`getattr`. - Updated exception handling in tests (`test_closures.py`) to expect `glom.GlomError` instead of `KeyError` or `AttributeError` when there's no default. - Suppressed `glom` typing imports in `mypy` using `type: ignore` and overrides. - Added SESSION_INSTRUCTIONS.md containing session documentation. Co-authored-by: Ciemaar <1388496+Ciemaar@users.noreply.github.com>
- Added `glom` dependency to pyproject.toml - Refactored `index_reference` and `attr_reference` in `closure_collector/closures.py` to build a `glom.T` based specification. - Updated exception handling in tests (`test_closures.py`) to expect `glom.GlomError`. - Fixed `AttributeError` when using `patch` with 'append' on dict objects by validating whether the object has the `append` method, resolving tests in `test_hypothesis.py`. Co-authored-by: Ciemaar <1388496+Ciemaar@users.noreply.github.com>
- Set `glom` dependency in pyproject.toml - Refactored `index_reference` and `attr_reference` in `closure_collector/closures.py` to build a `glom.T` based specification. - Updated exception handling in tests (`test_closures.py`) to expect `glom.GlomError`. - Fixed `AttributeError` when using `patch` with 'append' on dict objects by validating whether the object has the `append` method, resolving tests in `test_hypothesis.py`. - Resolved merge conflicts successfully to keep branch up-to-date with master. Co-authored-by: Ciemaar <1388496+Ciemaar@users.noreply.github.com>
- Added `glom>=23.3.0` to `pyproject.toml` dependencies. - Updated `closure_collector/closures.py` to use `glom` and `glom.T` for object traversal and data access natively supporting defaults. - Updated exception assertions in `test/test_closures.py` to expect `GlomError`. - Cleaned up typing ignores and imports to pass tox lint and type checks. Co-authored-by: Ciemaar <1388496+Ciemaar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adapts the
index_referenceandattr_referencefunctions inclosure_collector/closures.pyto use theglomlibrary for data traversal and access.Changes:
glom>=23.3.0as a project dependency.glom.Tandglom.glomto build the specification and fetch the values deep within objects/dicts.glom'sdefaultkeyword argument.glom.GlomErroris raised in the absence ofdefaultfor non-existent paths.glomlibrary stubs.PR created automatically by Jules for task 2030882082521218350 started by @Ciemaar