Skip to content

Replace alert with inline validation message for better UX #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sambhavi0 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Replace alert with inline validation message for better UX #774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2588ff
Replace alert with inline validation message for better UX
sambhavi0 Mar 23, 2026
9921bdf
Fix: remove recursive set_bits call to prevent error flicker
sambhavi0 Mar 23, 2026
3129a4b
Fix: added operator to do_bitwise
sambhavi0 Mar 23, 2026
64e36b7
Fixed const to variable
sambhavi0 Mar 23, 2026
47ceb04
improved changes
sambhavi0 Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions _includes/binary2.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@
max="255"
onkeypress="return event.charCode >= 48 && event.charCode <= 57"
/>
<p id="input-error" style="color: red; display: none; font-size: 14px;">
Only numbers between 0 and 255 can be entered.
</p>
<div class="active_operation">
OR
</div>
Expand Down
45 changes: 37 additions & 8 deletions assets/js/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,25 +23,54 @@ bit.fill(false);

function set_bits()
{
if(isNaN(document.getElementById("value_A").value) || document.getElementById("value_A").value > 255 || document.getElementById("value_A").value < 0 || isNaN(document.getElementById("value_B").value) || document.getElementById("value_B").value < 0 || document.getElementById("value_B").value > 255)
var errorEl = document.getElementById("input-error");
var bit_value;

if (
isNaN(document.getElementById("value_A").value) ||
document.getElementById("value_A").value > 255 ||
document.getElementById("value_A").value < 0 ||
isNaN(document.getElementById("value_B").value) ||
document.getElementById("value_B").value < 0 ||
document.getElementById("value_B").value > 255
)
{
document.getElementById("value_A").value = 0;
document.getElementById("value_B").value = 0;
alert("Only numbers between 0 and 255 can be entered.");
set_bits();

if (errorEl) {
errorEl.style.display = "block";
}
}
else
{
for(var i=0; i < 8; i++)
if (errorEl) {
errorEl.style.display = "none";
}

for (var i = 0; i < 8; i++)
{
if((document.getElementById("value_A").value&Math.pow(2,i))>0) { bit_value = true; } else { bit_value = false; }
if ((document.getElementById("value_A").value & Math.pow(2, i)) > 0) {
bit_value = true;
} else {
bit_value = false;
}

document.getElementById(i).innerHTML = bit_display[bit[i] = bit_value];
if((document.getElementById("value_B").value&Math.pow(2,i))>0) { bit_value = true; } else { bit_value = false; }
document.getElementById(i+8).innerHTML = bit_display[bit[i+8] = bit_value];

if ((document.getElementById("value_B").value & Math.pow(2, i)) > 0) {
bit_value = true;
} else {
bit_value = false;
}

document.getElementById(i + 8).innerHTML = bit_display[bit[i + 8] = bit_value];
}
do_bitwise();

do_bitwise(operator);
}
}
}

function toggle_bit(column)
{
Expand Down
Loading