Conversation
nathanthorpe
reviewed
Apr 1, 2026
cirro/cli/controller.py
Outdated
| datasets = cirro.datasets.list(project_id) | ||
| dataset_id = get_id_from_name(datasets, input_params['dataset']) | ||
|
|
||
| files = cirro.datasets.get_assets_listing(project_id, dataset_id).files |
Contributor
There was a problem hiding this comment.
would be a good time to check if we want to increase the file_limit param here.
Contributor
Author
There was a problem hiding this comment.
Added the file_limit parameter
nathanthorpe
reviewed
Apr 1, 2026
cirro/sdk/dataset.py
Outdated
| file_limit (int): Maximum number of files to return (default 100,000) | ||
| """ | ||
| files = self._get_assets().files | ||
| if file_limit != 100000: |
Contributor
There was a problem hiding this comment.
This logic seems unnecessary
Contributor
Author
There was a problem hiding this comment.
I agree. Just simplified it to remove the conditional
|
nathanthorpe
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding useful CLI methods.