Added NetFlow Exporter and Monitor tenant policy modules (DCNE-368 DCNE-369)#733
Added NetFlow Exporter and Monitor tenant policy modules (DCNE-368 DCNE-369)#733sajagana wants to merge 5 commits intoCiscoDevNet:masterfrom
Conversation
sajagana
force-pushed
the
652_netflow_monitor
branch
3 times, most recently
from
87578b5 to
eb1e410
Compare
sajagana
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
samiib and
shrsr
as code owners
sajagana
changed the title
github-actions
bot
changed the title
| required_if=[ | ||
| ["state", "absent", ["name", "uuid"], True], | ||
| ["state", "present", ["name", "uuid"], True], | ||
| ["state", "present", ["netflow_exporters"]], |
There was a problem hiding this comment.
Are we sure about this required_if condition?
At least one NetFlow exporter object must be attached to a NetFlow monitor during creation.
But our condition, here, extends that situation to even updates: every time we want to update NetFlow Monitor we need to provide the NetFlow exporters even though we don't want to update it (and it's not an identifier either so it's not really needed).
We should probably fix this.
Also the API returns a proper error when a NetFlow Monitor is created without at least one Exporter so we should probably rely on the API behavior for this. (Have you checked what happened when you update an existing correct Monitor object and you remove all Exporters from it? What is the API behavior here?)
There was a problem hiding this comment.
Thank you for the feedback! Updated module and test file.
sajagana
force-pushed
the
652_netflow_monitor
branch
from
2609955 to
4105bf8
Compare
sajagana
changed the title
| description: | ||
| - The NetFlow Record reference details for the NetFlow Monitor. | ||
| - Providing an empty dictionary O(netflow_record={}) will remove NetFlow Record from the NetFlow Monitor. | ||
| - Defaults to an empty string when unset during creation. |
There was a problem hiding this comment.
Is this intended to say empty dictionary or empty string?
There was a problem hiding this comment.
Removed the unwanted description.
…ndo_tenant_netflow_monitor.py
…bject - ndo_tenant_netflow_monitor.py module
sajagana
force-pushed
the
652_netflow_monitor
branch
from
2ee550b to
7e10953
Compare
4 participants
No description provided.