Connect timeout #295
Open
Connect timeout #295
+58
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayibrah
reviewed
Oct 6, 2025
|
|
||
| // Parse optional parameters | ||
| for _, option := range options { | ||
| switch v := option.(type) { |
| DefaultBackoffMaxDelay int = 60 | ||
| DefaultBackoffDelayFactor float64 = 3 | ||
| DefaultGnmiTimeout time.Duration = 15 * time.Second // Configurable gNMI timeout | ||
| DefaultConnectTimeout time.Duration = 30 * time.Second // Configurable connection timeout |
There was a problem hiding this comment.
Can you explain what the issue you try to slove and why we have two timeout ?
| cancel() // Clean up timeout context immediately | ||
|
|
||
| if err != nil { | ||
| c.Devices[device].SetMutex.Unlock() |
There was a problem hiding this comment.
The device unlock is already handled in the following lines.
| c.Devices[device].SetMutex.Lock() | ||
| if !c.ReuseConnection { | ||
| err = target.CreateGNMIClient(ctx) | ||
| // Create connection context with configurable timeout |
There was a problem hiding this comment.
Not sure why we’re adding two timeouts for the same gNMI call—check line 195.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection timeout for gnmi connection for user to connect